Skip to content

added roles for apt update and upgrade. added apt-upd role as depende…#273

Merged
und1sk0 merged 1 commit intomasterfrom
SAN-3259
Jan 19, 2016
Merged

added roles for apt update and upgrade. added apt-upd role as depende…#273
und1sk0 merged 1 commit intomasterfrom
SAN-3259

Conversation

@kaushikanurag
Copy link
Copy Markdown
Contributor

…ncy for builder role
Added new roles for apt update and apt upgrade

  • und1sk0

@und1sk0
Copy link
Copy Markdown
Contributor

und1sk0 commented Jan 15, 2016

Go ahead and test this on a dock or perhaps one of the secondary mongo DBs.

Should the upgrade role also reboot the server when it's finished, or do we prefer to do that by hand? (Thinking the latter.)

Also, can you add Anand as a secondary approver?

Do you intend to add the apt_upd role to each playbook?

@kaushikanurag
Copy link
Copy Markdown
Contributor Author

I had discussed it with Anand. He wanted add it as role that deploy git repro. Do have better idea where add the update in single location.

  • anandkumarpatel

@bkendall
Copy link
Copy Markdown
Contributor

Why apt_upd and apt_upg? apt_update and apt_upgrade are much more distinguishable in my mind (not just looking for a one-letter difference)... Just my two cents...

@und1sk0
Copy link
Copy Markdown
Contributor

und1sk0 commented Jan 18, 2016

Seconding Bryan's comment.

@anandkumarpatel
Copy link
Copy Markdown

+1 for renaming

@anandkumarpatel
Copy link
Copy Markdown

everything looks good, we will probably extend both of these roles in the future, but they are ok like this for now.

und1sk0 added a commit that referenced this pull request Jan 19, 2016
added roles for apt update and upgrade. added apt-upd role as depende…
@und1sk0 und1sk0 merged commit 9a4c943 into master Jan 19, 2016
@und1sk0 und1sk0 deleted the SAN-3259 branch January 19, 2016 23:25
@anandkumarpatel
Copy link
Copy Markdown

wait why was this merged? naming changes need to go in

@und1sk0
Copy link
Copy Markdown
Contributor

und1sk0 commented Jan 20, 2016

my bad though they were in. see #280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants